Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(engine): save original files for witness invalid block hook #11132

Merged
merged 3 commits into from
Sep 23, 2024
Merged

feat(engine): save original files for witness invalid block hook #11132

merged 3 commits into from
Sep 23, 2024

Conversation

shekhirin
Copy link
Collaborator

@shekhirin shekhirin commented Sep 23, 2024 •
edited
Loading

Fixes two issues:

  1. Trie Updates are taking too long to diff (2 minutes on mainnet), so let's just save the original and re-executed outputs
  2. Diffs can be confusing, let's also save original and re-executed/healthy files of all types (bundle state, witness, trie updates)

@shekhirin shekhirin changed the title feat(engine): save original files before diff for witness invalid blo… feat(engine): save original files for witness invalid block hook Sep 23, 2024
@shekhirin shekhirin added C-enhancement New feature or request A-consensus Related to the consensus engine A-observability Related to tracing, metrics, logs and other observability tools A-trie Related to Merkle Patricia Trie implementation labels Sep 23, 2024
@shekhirin shekhirin marked this pull request as ready for review September 23, 2024 16:29
@shekhirin shekhirin added this pull request to the merge queue Sep 23, 2024
Merged via the queue into main with commit 7b128d6 Sep 23, 2024
36 checks passed
@shekhirin shekhirin deleted the alexey/witness-block-hook-files branch September 23, 2024 16:57
ewoolsey pushed a commit to ewoolsey/reth that referenced this pull request Sep 25, 2024
@shekhirin @ewoolsey
feat(engine): save original files for witness invalid block hook (par…
0f88e4e 
…adigmxyz#11132)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkrasiuk rkrasiuk rkrasiuk approved these changes

@Rjected Rjected Rjected approved these changes

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-consensus Related to the consensus engine A-observability Related to tracing, metrics, logs and other observability tools A-trie Related to Merkle Patricia Trie implementation C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shekhirin @Rjected @rkrasiuk