feat: tx and receipt compression utils for no-std config #11112
Conversation
nadtech-hub
changed the title
| @@ -38,6 +39,38 @@ thread_local! { | |||
| )); | |||
| } | |||
|
|
|||
| /// Tx compressor creator | |||
There was a problem hiding this comment.
please update these comments to be in the same style as the rest of the codebase, i.e. "Creates a [Compressor] for transactions" or something like that
nadtech-hub
changed the title
nadtech-hub
changed the title
| #[cfg(feature = "std")] | ||
| use std::thread_local; |
There was a problem hiding this comment.
please use full paths instead of feature gating imports
There was a problem hiding this comment.
Remove macro above import?
There was a problem hiding this comment.
you can use std::thread_local! directly
nadtech-hub
changed the title
|
Functionality wise looks fine, but i'm not entirely sure of the overhead of doing this for each tx/receipt. Maybe for |
nadtech-hub
force-pushed
the
feature/nostd-compression-utils
branch
from
d119729
to
8a4947b
Compare
| let mut compressor = compressor.borrow_mut(); | ||
| let mut tmp = Vec::with_capacity(256); | ||
| let mut tmp = Vec::with_capacity(256); | ||
| if cfg!(feature = "std") { |
There was a problem hiding this comment.
I've viewed that crate. I can't foresee more than 2 if-else branches in this place, therefore this crate doesn't seem much useful
| @@ -38,6 +38,35 @@ thread_local! { | |||
| )); | |||
| } | |||
|
|
|||
| /// Fn creates as many tx compressors per thread as times its called. It is meant to be used in no-std config | |||
There was a problem hiding this comment.
| /// Fn creates as many tx compressors per thread as times its called. It is meant to be used in no-std config | |
| /// Creates a [`Compressor`] for transactions. |
joshieDo
added
A-db
|
lint / fmt script fails on my machine as well as in pipeline. @joshieDo could you help me with this? |
|
if you run either |
@joshieDo |
Tx and receipt compression utils for no-std environment.