fix(storage): dont skip consistency checks for op-mainnet if using minimal bootstrap
#11099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshieDo
changed the title
op-mainnetop-mainnet
|
blocked by #9739 |
joshieDo
removed
the
S-blocked
joshieDo
changed the title
op-mainnetop-mainnet if using minimal bootstrap
emhane
requested changes
Sep 22, 2024
| if provider.chain_spec().chain() == Chain::optimism_mainnet() && | ||
| provider | ||
| .block_number(b256!( | ||
| "bee7192e575af30420cae0c7776304ac196077ee72b048970549e4f08e875453" |
There was a problem hiding this comment.
please define as constant in reth_optimism_primitives::bedrock
emhane
approved these changes
Sep 22, 2024
emhane
reviewed
Sep 22, 2024
mattsse
approved these changes
Sep 24, 2024
| // | ||
| // If we detect an OVM import was done (block #1 <https://optimistic.etherscan.io/block/1>), skip it. | ||
| // More on [#11099](https://github.com/paradigmxyz/reth/pull/11099). | ||
| #[cfg(feature = "optimism")] |
There was a problem hiding this comment.
we can keep this cfg, but not strictly required because not expensive to check and only reachable by op mainnet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reverting #9737
Storage consistency ensures that:
Currently, OVM import of receipts seems to be broken (#10580, #9739) (#9725).
Any node that synced to the tip after #9737 may be inconsistent (from a historical storage pov), and disabling this skip entirely would break them. Static files are not a database, so a migration may be possible, but more complex.
For now, leaving this check disabled for nodes which imported the ovm historical data (use minimal bootstrap instead). But it's important to understand that a sudden crash of the node MAY break it.