-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rpc: rm useless alloy_rpc_types_debug
reexport
#11095
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcoratger
requested review from
mattsse,
Rjected,
emhane and
gakonst
as code owners
September 21, 2024 19:34
onbjerg
approved these changes
Sep 21, 2024
onbjerg
added
C-debt
Refactor of code section that is hard to understand or maintain
A-rpc
Related to the RPC implementation
labels
Sep 21, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Sep 21, 2024
emhane
approved these changes
Sep 22, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Sep 22, 2024
mattsse
approved these changes
Sep 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pending conflicts
ewoolsey
pushed a commit
to ewoolsey/reth
that referenced
this pull request
Sep 25, 2024
Co-authored-by: Emilia Hane <elsaemiliaevahane@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #11067