feat(rpc): Replace TypedTransactionType #11089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenpaff
commented
Sep 21, 2024
jenpaff
commented
Sep 21, 2024
jenpaff
force-pushed
the
jenpaff/replace-typed-transaction-type
branch
from
628af0d
to
5a2d892
Compare
mattsse
requested changes
Sep 23, 2024
crates/rpc/rpc-eth-api/Cargo.toml
Outdated
| @@ -21,7 +21,7 @@ reth-evm.workspace = true | |||
| reth-primitives.workspace = true | |||
| reth-provider.workspace = true | |||
| reth-revm.workspace = true | |||
| reth-rpc-types.workspace = true | |||
| # reth-rpc-types.workspace = true | |||
There was a problem hiding this comment.
cool, can we remove this entirely?
There was a problem hiding this comment.
yes after I rebased seems like it's not used anymore at all- will have a go at removing entirely
There was a problem hiding this comment.
@mattsse I feel like this reth-rpc-types doesn't do much anymore, should I give it a go to remove it fully ? (in this or separate pr)?
Comment on lines
90
to
94
| // create local signer wallet from signing key | ||
| let sk_bytes = self.accounts.get(address).ok_or(SignError::NoAccount)?.secret_bytes(); | ||
| let wallet = | ||
| PrivateKeySigner::from_bytes(&sk_bytes.into()).map_err(|_| SignError::NoAccount)?; | ||
| let signer = EthereumWallet::from(wallet); |
There was a problem hiding this comment.
perhaps we can simplify this by changing SecretKey to
PrivateKeySigner?
see also PrivateKeySigner::random_{with}
There was a problem hiding this comment.
updated now using signer api
jenpaff
force-pushed
the
jenpaff/replace-typed-transaction-type
branch
from
b188cea
to
cd23c92
Compare
mattsse
changed the title
mattsse
added
C-debt
mattsse
requested changes
Sep 24, 2024
Comment on lines
60
to
62
| let sk = self.get_key(account)?.to_field_bytes(); | ||
| let signature = sign_message(B256::from_slice(sk.as_ref()), hash); | ||
| signature.map_err(|_| SignError::CouldNotSign) |
There was a problem hiding this comment.
you can use the signer API here:
use alloy_signer::signer::SignerSync;
let sk = self.get_key(account)?.sign_hash_sync
jenpaff
force-pushed
the
jenpaff/replace-typed-transaction-type
branch
from
d536c3b
to
070debb
Compare
jenpaff
commented
Sep 25, 2024
| to_primitive_transaction(request).ok_or(SignError::InvalidTransactionRequest)?; | ||
| let tx_signature_hash = transaction.signature_hash(); | ||
| let signature = self.sign_hash(tx_signature_hash, *address)?; | ||
| // create local signer wallet from signing key |
jenpaff
commented
Sep 25, 2024
crates/rpc/rpc-types/src/lib.rs
Outdated
| #[cfg(feature = "jsonrpsee-types")] | ||
| pub use eth::{ | ||
| engine, | ||
| engine::{ | ||
| ExecutionPayload, ExecutionPayloadV1, ExecutionPayloadV2, ExecutionPayloadV3, PayloadError, | ||
| }, | ||
| }; | ||
|
|
||
| use alloy_primitives as _; |
There was a problem hiding this comment.
possibly could be removed can look into it
mattsse
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards closing #7490
Quick vibe check if I'm going the right way here