Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(discv5): change default discv5 port #11051

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Conversation

Rjected
Copy link
Member

@Rjected Rjected commented Sep 19, 2024

If discv5 is enabled while also running a lighthouse or other CL node that uses 9000 for its default port, then this will conflict and fail. Since op-reth nodes use discv5 and are often run on the same machine as a mainnet CL, it does not make sense to conflict by default. So this changes the default to 9200 which should prevent conflicts by default, and allow for many --instance nodes to run without conflicting

@Rjected Rjected added C-bug An unexpected or incorrect behavior A-cli Related to the reth CLI labels Sep 19, 2024
@onbjerg
Copy link
Member

onbjerg commented Sep 20, 2024

The test failure is due to ListenConfig::default being used, which defaults to port 9000. I've addressed it in #11060 which is stacked on top of this PR. I didn't do the work in this PR because I'm not sure if there's a better way to solve it:)

Also marked with M-changelog since we'd likely want to highlight that it changed if people have done port forwarding

@onbjerg onbjerg added the M-changelog This change should be included in the changelog label Sep 20, 2024
@onbjerg onbjerg added this pull request to the merge queue Sep 20, 2024
Merged via the queue into main with commit 84db469 Sep 20, 2024
35 checks passed
@onbjerg onbjerg deleted the dan/fix-discv5-conflicts branch September 20, 2024 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Related to the reth CLI C-bug An unexpected or incorrect behavior M-changelog This change should be included in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants