Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add blocks_per_file field to StaticFileProvider #11043

Merged
merged 5 commits into from
Sep 19, 2024
Merged

Conversation

joshieDo
Copy link
Collaborator

The number of blocks per file has been a const. This PR makes it configurable so it's easier to create test scenarios that cover #11021 #11029 without creating 500k chains

@joshieDo joshieDo added C-test A change that impacts how or what we test A-static-files Related to static files labels Sep 19, 2024
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reasonable, one suggestion

@joshieDo joshieDo added this pull request to the merge queue Sep 19, 2024
Merged via the queue into main with commit 69c8ddb Sep 19, 2024
35 checks passed
@joshieDo joshieDo deleted the joshie/findrange branch September 19, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-static-files Related to static files C-test A change that impacts how or what we test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants