Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove windows cfg #11002

Merged
merged 1 commit into from
Sep 18, 2024
Merged

chore: remove windows cfg #11002

merged 1 commit into from
Sep 18, 2024

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Sep 18, 2024

same function also exists on windows, no reason to feature gate

emhane
emhane reviewed Sep 18, 2024
View reviewed changes
Copy link
Member

@emhane emhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you try it out on a windows machine, cause docs say the opposite ?

@mattsse
Copy link
Collaborator Author

mattsse commented Sep 18, 2024

only looked at source code, function exists

@mattsse mattsse added this pull request to the merge queue Sep 18, 2024
Merged via the queue into main with commit 000b412 Sep 18, 2024
36 checks passed
@mattsse mattsse deleted the matt/rm-windows-cfgs branch September 18, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emhane emhane emhane left review comments

@rkrasiuk rkrasiuk rkrasiuk approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattsse @rkrasiuk @emhane