Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): expose tree engine persistence configuration #10999

Merged
merged 5 commits into from
Sep 18, 2024
Merged

feat(cli): expose tree engine persistence configuration #10999

merged 5 commits into from
Sep 18, 2024

Conversation

rkrasiuk
Copy link
Member

Description

Expose persistence related experimental engine tree configuration through CLI.

@rkrasiuk rkrasiuk added C-enhancement New feature or request A-consensus Related to the consensus engine A-cli Related to the reth CLI labels Sep 18, 2024
mattsse
mattsse approved these changes Sep 18, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps this is something we want to move into regular config, but we can do this later

@rkrasiuk rkrasiuk added this pull request to the merge queue Sep 18, 2024
Merged via the queue into main with commit f64aecf Sep 18, 2024
35 checks passed
@rkrasiuk rkrasiuk deleted the rkrasiuk/expose-engine-tree-persistence-config branch September 18, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshieDo joshieDo joshieDo approved these changes

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@emhane emhane Awaiting requested review from emhane emhane is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-cli Related to the reth CLI A-consensus Related to the consensus engine C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rkrasiuk @mattsse @joshieDo