Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

emv: add BlockHeader trait and default fill_block_env #10993

Merged
merged 1 commit into from
Sep 18, 2024
Merged

emv: add BlockHeader trait and default fill_block_env #10993

merged 1 commit into from
Sep 18, 2024

Conversation

tcoratger
Copy link
Contributor

Experimentation related to alloy-rs/alloy#1302

cc @mattsse @emhane

mattsse
mattsse approved these changes Sep 18, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we def want this, though not ruling out changes.

i like this approach, I think we could something similar with transactions.

and perhaps unify with alloy traits once we renamed Headerresponse @klkvr

@onbjerg for vis re alphanet

@mattsse mattsse added the A-execution Related to the Execution and EVM label Sep 18, 2024
@mattsse mattsse added this pull request to the merge queue Sep 18, 2024
Merged via the queue into paradigmxyz:main with commit 06b9792 Sep 18, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emhane emhane emhane approved these changes

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-execution Related to the Execution and EVM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tcoratger @mattsse @emhane