Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make error msg conform to normal usage #10988

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

0xkrane
Copy link
Contributor

@0xkrane 0xkrane commented Sep 18, 2024

Was reading: #10835 and preceding PR to attempt it and saw that generally GotExpected messages have the format of using a message of the form: *mismatch* so conforming to that format on this one as well

@0xkrane 0xkrane marked this pull request as ready for review September 18, 2024 14:05
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reasonable

@mattsse mattsse added the A-observability Related to tracing, metrics, logs and other observability tools label Sep 18, 2024
@mattsse mattsse added this pull request to the merge queue Sep 18, 2024
Merged via the queue into paradigmxyz:main with commit a92017b Sep 18, 2024
36 checks passed
@0xkrane 0xkrane deleted the krane/sender-recovery branch September 23, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-observability Related to tracing, metrics, logs and other observability tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants