Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(primitives, ethereum-forks): replace std feature gate alloc imports #10945

Merged
merged 1 commit into from
Sep 17, 2024
Merged

chore(primitives, ethereum-forks): replace std feature gate alloc imports #10945

merged 1 commit into from
Sep 17, 2024

Conversation

nkysg
Copy link
Contributor

@nkysg nkysg commented Sep 17, 2024

Ref #10853

nkysg
nkysg commented Sep 17, 2024
View reviewed changes
crates/ethereum-forks/src/hardforks/mod.rs
@@ -13,7 +13,8 @@ use rustc_hash::FxHashMap;
use std::collections::hash_map::Entry;

#[cfg(not(feature = "std"))]
use alloc::{boxed::Box, collections::btree_map::Entry, vec::Vec};
use alloc::collections::btree_map::Entry;
Copy link
Contributor Author

@nkysg nkysg Sep 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this place can replace FxHashMap with alloc::collections::btree_map, then no need gate feature std, @mattsse @Rjected

@mattsse mattsse added this pull request to the merge queue Sep 17, 2024
Merged via the queue into paradigmxyz:main with commit f04fc7c Sep 17, 2024
36 checks passed
@nkysg nkysg deleted the cfg_alloc branch September 17, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nkysg @mattsse