Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use DbProvider on UnifiedStorageWriter #10933

Merged
merged 4 commits into from
Sep 16, 2024
Merged

feat: use DbProvider on UnifiedStorageWriter #10933

merged 4 commits into from
Sep 16, 2024

Conversation

joshieDo
Copy link
Collaborator

  • use DbProvider on UnifiedStorageWriter
  • removes DB: Database

@joshieDo joshieDo added C-enhancement New feature or request A-db Related to the database labels Sep 16, 2024
joshieDo
joshieDo commented Sep 16, 2024
View reviewed changes
crates/storage/provider/src/writer/mod.rs
pub fn commit_unwind<DB: Database>(
database: DatabaseProviderRW<DB>,
pub fn commit_unwind<P>(
database: impl Into<P> + AsRef<P>,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AsRef helps rust on type inference

@joshieDo
Copy link
Collaborator Author

joshieDo commented Sep 16, 2024 •
edited
Loading

ci failure unrelated

@klkvr klkvr added this pull request to the merge queue Sep 16, 2024
Merged via the queue into main with commit 66848d9 Sep 16, 2024
35 checks passed
@klkvr klkvr deleted the joshie/unified-writer branch September 16, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klkvr klkvr klkvr approved these changes

@mattsse mattsse Awaiting requested review from mattsse

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

Assignees
No one assigned
Labels
A-db Related to the database C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshieDo @klkvr