Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove unnecessary segment argument from StaticFileProviderRW #10882

Merged
merged 2 commits into from
Sep 13, 2024
Merged

chore: remove unnecessary segment argument from StaticFileProviderRW #10882

merged 2 commits into from
Sep 13, 2024

Conversation

joshieDo
Copy link
Collaborator

No description provided.

@joshieDo joshieDo added C-debt Refactor of code section that is hard to understand or maintain A-static-files Related to static files labels Sep 13, 2024
mattsse
mattsse approved these changes Sep 13, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@joshieDo joshieDo added this pull request to the merge queue Sep 13, 2024
Merged via the queue into main with commit d3acd09 Sep 13, 2024
34 checks passed
@joshieDo joshieDo deleted the joshie/segment-arg branch September 13, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

Assignees
No one assigned
Labels
A-static-files Related to static files C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshieDo @mattsse