Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): ensure reth init-state doesn't end in an invalid state root #10880

Merged
merged 2 commits into from
Sep 13, 2024
Merged

fix(cli): ensure reth init-state doesn't end in an invalid state root #10880

merged 2 commits into from
Sep 13, 2024

Conversation

joshieDo
Copy link
Collaborator

  • state root should match the one found in the header.
  • if the computed state root didn't match the one in dump, we were logging it but proceeding with the database commit anyway.

@joshieDo joshieDo added C-bug An unexpected or incorrect behavior A-cli Related to the reth CLI labels Sep 13, 2024
mattsse
mattsse approved these changes Sep 13, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is only relevant for op mainnet insert logic, right?

@joshieDo
Copy link
Collaborator Author

joshieDo commented Sep 13, 2024 •
edited
Loading

its relevant for whoever uses this command (op-reth or reth), mostly for op-mainnet since it's the one chain that requires this command

@joshieDo joshieDo added this pull request to the merge queue Sep 13, 2024
@joshieDo joshieDo removed this pull request from the merge queue due to a manual request Sep 13, 2024
@joshieDo joshieDo added this pull request to the merge queue Sep 13, 2024
Merged via the queue into main with commit 2ae53e5 Sep 13, 2024
34 checks passed
@joshieDo joshieDo deleted the joshie/init-state-fix branch September 13, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

Assignees
No one assigned
Labels
A-cli Related to the reth CLI C-bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshieDo @mattsse