perf: improve genesis handling #10878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onbjerg
previously requested changes
Sep 13, 2024
onbjerg
added
the
C-perf
mattsse
approved these changes
Sep 13, 2024
| @@ -275,7 +277,11 @@ impl ChainSpec { | |||
| } | |||
|
|
|||
| /// Get the header for the genesis block. | |||
| pub fn genesis_header(&self) -> Header { | |||
| pub fn genesis_header(&self) -> &Header { | |||
| self.genesis_header.get_or_init(|| self.make_genesis_header()) | |||
There was a problem hiding this comment.
cool, this definitely works
mattsse
approved these changes
Sep 13, 2024
|
smol import conflict |
onbjerg
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OnceLockfields; these are currently computed at least 2 times each on each reth invocation, if not more (sealed_genesis_headercomputes header and hash which itself computes header again if not set)impl HistoryWriter for DatabaseProviderby passing required values inimpl IntoIteratorsinit_genesis; it's not really "cheap" to clone (5 arcs +PruneModeswhich could allocate)