-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(reth): bin/reth missing help msg of segment #10873
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 9547 <29431502+9547@users.noreply.github.com>
@mattsse ptal |
onbjerg
previously requested changes
Sep 13, 2024
onbjerg
added
C-bug
An unexpected or incorrect behavior
A-cli
Related to the reth CLI
labels
Sep 13, 2024
mattsse
requested changes
Sep 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah let's move this to commands, otherwise everyone that pulls this in needs to enable it as well.
mattsse
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As found in #10856 (comment)
when building reth without
--workspace
, the output of the binary doesn't have the help message of SEGMENT:but when building with
--workspace
, refreth/.github/workflows/lint.yml
Lines 143 to 149 in 817b152
then it contains the segment info:
Then found the define of StaticFileSegment has an
cfg_attr
reth/crates/static-file/types/src/segment.rs
Lines 24 to 26 in 817b152
So I think we need to implictly import the
reth_static_file_types
crate