cfg: replace std feature gate alloc imports with extern crate alloc #10861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emhane
approved these changes
Sep 12, 2024
| @@ -1,9 +1,7 @@ | |||
| use alloc::vec::Vec; | |||
| use std::{cell::RefCell, thread_local}; | |||
There was a problem hiding this comment.
yeah I found this one, seems strange that is passes the no-std compilation before no?
There was a problem hiding this comment.
For Refcell I think we should use use core::cell::RefCell; but for thread_local, I don't think this is available so maybe we should keep as is no?
There was a problem hiding this comment.
yepp, would be great if you can open an issue for replacing thread_local with smthg that works
There was a problem hiding this comment.
- Fixed RefCell
- Created the issue std: fix
std::thread_localdep for no-std config #10871
mattsse
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #10853