feat(engine): compare invalid block witness against a healthy node #10844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shekhirin
force-pushed
the
alexey/invalid-block-hook-healthy-node-rpc-url
branch
from
83f3f65
to
f2d12f7
Compare
shekhirin
added
C-enhancement
shekhirin
requested review from
mattsse,
Rjected,
onbjerg,
rkrasiuk,
fgimenez and
gakonst
as code owners
Rjected
requested changes
Sep 12, 2024
Comment on lines
+871
to
+876
| let chain_id = futures::executor::block_on(async { | ||
| EthApiClient::< | ||
| reth_rpc_types::Transaction, | ||
| reth_rpc_types::Block, | ||
| reth_rpc_types::Receipt, | ||
| >::chain_id(&client) |
There was a problem hiding this comment.
makes me wonder if we should just provide a blocking api in EthApiClient somehow, but not something to address in this PR
|
needs doctest renames |
mattsse
reviewed
Sep 13, 2024
| let client = jsonrpsee::http_client::HttpClientBuilder::default().build(url)?; | ||
|
|
||
| // Verify that the healthy node is running the same chain as the current node. | ||
| let chain_id = futures::executor::block_on(async { |
There was a problem hiding this comment.
do we even need this check?
I mean this is a debug feature, so do we need to explicitly check this
There was a problem hiding this comment.
i'd prefer to have it so we don't end up in a situation when generated witness diff is incorrect and we spend time figuring out why
shekhirin
force-pushed
the
alexey/invalid-block-hook-healthy-node-rpc-url
branch
from
64ac568
to
8b3969d
Compare
shekhirin
force-pushed
the
alexey/invalid-block-hook-healthy-node-rpc-url
branch
from
8b3969d
to
b980b8c
Compare
…hook-healthy-node-rpc-url
shekhirin
deleted the
alexey/invalid-block-hook-healthy-node-rpc-url
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10549
Adds a
--debug.healthy-node-rpc-urlCLI argument that initializes an RPC client, checks if the chain ID matches, and passes the client to the witness invalid block hook.Later, if the witness hook is triggered, we query the healthy node for the witness of the same block, save the output in a separate file and compare it against the original one.