Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

error: use derive-more Error for deriving error #10841

Merged
merged 6 commits into from
Sep 17, 2024
Merged

error: use derive-more Error for deriving error #10841

merged 6 commits into from
Sep 17, 2024

Conversation

tcoratger
Copy link
Contributor

Related #10828

@onbjerg onbjerg added the C-debt Refactor of code section that is hard to understand or maintain label Sep 12, 2024
emhane
emhane reviewed Sep 12, 2024
View reviewed changes
crates/storage/errors/src/writer.rs Outdated Show resolved Hide resolved
crates/net/p2p/src/error.rs Outdated Show resolved Hide resolved
crates/net/p2p/src/error.rs Outdated Show resolved Hide resolved
tcoratger
tcoratger commented Sep 12, 2024
View reviewed changes
crates/net/p2p/src/error.rs Outdated Show resolved Hide resolved
crates/storage/errors/src/writer.rs Outdated Show resolved Hide resolved
onbjerg
onbjerg approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@onbjerg onbjerg added this pull request to the merge queue Sep 17, 2024
Merged via the queue into paradigmxyz:main with commit 1d0b18c Sep 17, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emhane emhane emhane approved these changes

@mattsse mattsse mattsse approved these changes

@onbjerg onbjerg onbjerg approved these changes

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

Assignees
No one assigned
Labels
C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tcoratger @onbjerg @mattsse @emhane