-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(download): body download range #1065
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1065 +/- ##
==========================================
+ Coverage 75.13% 75.21% +0.07%
==========================================
Files 313 313
Lines 34305 34299 -6
==========================================
+ Hits 25776 25797 +21
+ Misses 8529 8502 -27
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Fix the logic around reset of the download range and terminating conditions for
query_headers
function:Download range end was not taken into account when downloading blocks.(because it's exclusive, duh)request_range
inset_download_range
was not actually added to the queue123..0
)StageError::Download
is now considered fatal