Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(hive): remove eth_createAccessList tests from expected failures #10601

Merged
merged 1 commit into from
Aug 28, 2024
Merged

fix(hive): remove eth_createAccessList tests from expected failures #10601

merged 1 commit into from
Aug 28, 2024

Conversation

joshieDo
Copy link
Collaborator

@joshieDo joshieDo commented Aug 28, 2024 •
edited
Loading

These tests have been passing since yesterday (#10422 solved it)

@joshieDo joshieDo added C-hivetest Used for labelling automated issues relating to hive test failures A-ci Related to github workflows or other build and lint tools labels Aug 28, 2024
@joshieDo joshieDo requested a review from Rjected August 28, 2024 16:57
Rjected
Rjected approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@joshieDo joshieDo added this pull request to the merge queue Aug 28, 2024
Merged via the queue into main with commit 4227055 Aug 28, 2024
37 checks passed
@joshieDo joshieDo deleted the push-lwvxplolrxkr branch August 28, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rjected Rjected Rjected approved these changes

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

Assignees
No one assigned
Labels
A-ci Related to github workflows or other build and lint tools C-hivetest Used for labelling automated issues relating to hive test failures
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshieDo @Rjected