Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only set isSystemtx if true #10496

Merged
merged 2 commits into from
Aug 24, 2024
Merged

fix: only set isSystemtx if true #10496

merged 2 commits into from
Aug 24, 2024

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Aug 24, 2024

ref #10463

@mattsse mattsse added A-rpc Related to the RPC implementation A-op-reth Related to Optimism and op-reth labels Aug 24, 2024
@mattsse mattsse enabled auto-merge August 24, 2024 07:35
onbjerg
onbjerg approved these changes Aug 24, 2024
View reviewed changes
Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if i understand correctly, this fix makes it so we dont have is_system_tx: Some(false), instead Some(false) would now be None

@mattsse mattsse added this pull request to the merge queue Aug 24, 2024
Merged via the queue into main with commit bcb0a23 Aug 24, 2024
34 checks passed
@mattsse mattsse deleted the matt/set-is-system-only-if-systemtx branch August 24, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onbjerg onbjerg onbjerg approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@emhane emhane Awaiting requested review from emhane emhane is a code owner

Assignees
No one assigned
Labels
A-op-reth Related to Optimism and op-reth A-rpc Related to the RPC implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsse @onbjerg