dev(pool): trait object safe BestTransactions
#10478
Conversation
greged93
force-pushed
the
dev/best-transactions-filter
branch
from
9b271e2
to
572836e
Compare
| // Create a filter that only returns transactions with even nonces | ||
| let filter = | ||
| BestTransactionFilter::new(best, |tx: &Arc<ValidPoolTransaction<MockTransaction>>| { | ||
| tx.nonce() % 2 == 0 | ||
| }); |
There was a problem hiding this comment.
this should use the trait function on best
There was a problem hiding this comment.
Do you mean the trait function filter? I can't use it because of the Sized requirement
There was a problem hiding this comment.
ah I see, then this won't be very useful because we usually operate on Box<dyn and won't be much different from the previous impl right? so what does this change actually achieve?
| @@ -162,6 +164,8 @@ impl<T: TransactionOrdering> crate::traits::BestTransactions for BestTransaction | |||
| } | |||
| } | |||
|
|
|||
| impl<T: TransactionOrdering> crate::traits::BestTransactionsFilter for BestTransactions<T> {} | |||
There was a problem hiding this comment.
can we try replacing this with a blanket impl
filter for T where T: BestTransaction
There was a problem hiding this comment.
this makes a lot of sense and seems possible, will add
| // Create a filter that only returns transactions with even nonces | ||
| let filter = | ||
| BestTransactionFilter::new(best, |tx: &Arc<ValidPoolTransaction<MockTransaction>>| { | ||
| tx.nonce() % 2 == 0 | ||
| }); |
There was a problem hiding this comment.
ah I see, then this won't be very useful because we usually operate on Box<dyn and won't be much different from the previous impl right? so what does this change actually achieve?
|
The idea was to make this work for a This builds towards #10437, making it then possible to filter the transactions returned by Let me know if this makes sense or if you would rather change something. |
|
gotcha, now I understood. is this possible if not this is complete |
greged93
force-pushed
the
dev/best-transactions-filter
branch
from
572836e
to
82b3f50
Compare
BestTransactionsin two traits in order to make theBestTransactionstrait object safe.BestTransactionsFiltertrait object that verifies that the predicates only keeps transactions with even nonces.