Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(txpool): rename the function of tx_by_sender_and_nonce #10473

Merged
merged 1 commit into from
Aug 24, 2024
Merged

chore(txpool): rename the function of tx_by_sender_and_nonce #10473

merged 1 commit into from
Aug 24, 2024

Conversation

jsvisa
Copy link
Contributor

@jsvisa jsvisa commented Aug 23, 2024

This function only returns one tx, so we should use transaction instead of transactions, else the user may be confused about whether a sender+nonce will return one or more txs.

@jsvisa
chore(txpool): rename the function of tx_by_sender_and_nonce
45e4db5 
Signed-off-by: jsvisa <delweng@gmail.com>
@jsvisa jsvisa requested a review from mattsse as a code owner August 23, 2024 04:26
mattsse
mattsse approved these changes Aug 24, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty

@mattsse mattsse added this pull request to the merge queue Aug 24, 2024
@mattsse mattsse added the A-tx-pool Related to the transaction mempool label Aug 24, 2024
Merged via the queue into paradigmxyz:main with commit 3d2de47 Aug 24, 2024
35 checks passed
@jsvisa jsvisa deleted the txpool-get-tx-by-nonce branch August 24, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

Assignees
No one assigned
Labels
A-tx-pool Related to the transaction mempool
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsvisa @mattsse