Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace ForkChoiceStream type with generic stream type #10458

Merged
merged 1 commit into from
Aug 23, 2024
Merged

refactor: replace ForkChoiceStream type with generic stream type #10458

merged 1 commit into from
Aug 23, 2024

Conversation

jenpaff
Copy link
Collaborator

@jenpaff jenpaff commented Aug 22, 2024

Closes #10392

@github-actions github-actions bot added C-debt Refactor of code section that is hard to understand or maintain C-enhancement New feature or request labels Aug 22, 2024
@jenpaff jenpaff marked this pull request as ready for review August 22, 2024 18:59
onbjerg
onbjerg approved these changes Aug 23, 2024
View reviewed changes
Copy link
Member

@onbjerg onbjerg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, i also like the name ForkChoiceStream

crates/chain-state/src/notifications.rs Show resolved Hide resolved
@onbjerg onbjerg changed the title Replace ForkChoiceStream type with generic stream type refactor: replace ForkChoiceStream type with generic stream type Aug 23, 2024
@jenpaff jenpaff force-pushed the jenpaff/replace-forkstream-with-generic-type branch from 835bc06 to 6f8da35 Compare August 23, 2024 14:02
@jenpaff jenpaff added this pull request to the merge queue Aug 23, 2024
Merged via the queue into main with commit 0791b9e Aug 23, 2024
35 checks passed
@jenpaff jenpaff deleted the jenpaff/replace-forkstream-with-generic-type branch August 23, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onbjerg onbjerg onbjerg approved these changes

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

Assignees
No one assigned
Labels
C-debt Refactor of code section that is hard to understand or maintain C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace ForkChoiceStream type with generic stream type
2 participants
@jenpaff @onbjerg