Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for withdrawals provider #10428

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Add tests for withdrawals provider #10428

merged 1 commit into from
Aug 22, 2024

Conversation

jenpaff
Copy link
Collaborator

@jenpaff jenpaff commented Aug 21, 2024 •
edited
Loading

Closes #10342

ended up being more invasive since I needed to extend random_block function

@shekhirin shekhirin added A-db Related to the database C-test A change that impacts how or what we test A-blockchain-tree Related to sidechains, reorgs and pending blocks labels Aug 21, 2024
@jenpaff jenpaff force-pushed the jenpaff/test-withdrawals-provider-of-blockchain-provider branch from e3796ef to 1d29af6 Compare August 21, 2024 19:08
@shekhirin
Copy link
Collaborator

It has a bunch of conflicts due to new helpers that were added, can you pls resolve them?

@jenpaff
Copy link
Collaborator Author

jenpaff commented Aug 22, 2024

It has a bunch of conflicts due to new helpers that were added, can you pls resolve them?

on it, apologies for the delay

@jenpaff jenpaff force-pushed the jenpaff/test-withdrawals-provider-of-blockchain-provider branch from 1d29af6 to 51c089b Compare August 22, 2024 15:41
@jenpaff jenpaff marked this pull request as ready for review August 22, 2024 15:54
emhane
emhane approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@emhane emhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

shekhirin
shekhirin requested changes Aug 22, 2024
View reviewed changes
Copy link
Collaborator

@shekhirin shekhirin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

random_block(s) function arguments grow even bigger -.- Let's leave it as-is for this PR, but we should refactor this into using struct for optional fields

crates/storage/provider/src/providers/blockchain_provider.rs Outdated Show resolved Hide resolved
testing/testing-utils/src/generators.rs Outdated Show resolved Hide resolved
testing/testing-utils/src/generators.rs Outdated Show resolved Hide resolved
testing/testing-utils/src/generators.rs Outdated Show resolved Hide resolved
@jenpaff jenpaff mentioned this pull request Aug 22, 2024
Closed
@jenpaff
Copy link
Collaborator Author

jenpaff commented Aug 22, 2024

random_block(s) function arguments grow even bigger -.- Let's leave it as-is for this PR, but we should refactor this into using struct for optional fields

Created an issue & assigned myself, can pick it up next #10457 . I'm unsure which lablels to add though

@jenpaff jenpaff force-pushed the jenpaff/test-withdrawals-provider-of-blockchain-provider branch from 51c089b to 2b4a6da Compare August 22, 2024 17:49
@jenpaff jenpaff requested a review from shekhirin August 22, 2024 18:06
shekhirin
shekhirin approved these changes Aug 22, 2024
View reviewed changes
Copy link
Collaborator

@shekhirin shekhirin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last pedantic nit, LGTM otherwise!

crates/storage/provider/src/providers/blockchain_provider.rs Outdated Show resolved Hide resolved
@jenpaff jenpaff force-pushed the jenpaff/test-withdrawals-provider-of-blockchain-provider branch from 280a710 to 7a85d9d Compare August 22, 2024 19:09
@jenpaff jenpaff added this pull request to the merge queue Aug 22, 2024
Merged via the queue into main with commit 24495cd Aug 22, 2024
34 checks passed
@jenpaff jenpaff deleted the jenpaff/test-withdrawals-provider-of-blockchain-provider branch August 22, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emhane emhane emhane approved these changes

@shekhirin shekhirin shekhirin approved these changes

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-blockchain-tree Related to sidechains, reorgs and pending blocks A-db Related to the database C-test A change that impacts how or what we test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test WithdrawalsProvider implementation of BlockchainProvider2<DB>
3 participants
@jenpaff @shekhirin @emhane