Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev(primitives): signature conversion #10371

Merged
merged 2 commits into from
Aug 17, 2024
Merged

dev(primitives): signature conversion #10371

merged 2 commits into from
Aug 17, 2024

Conversation

greged93
Copy link
Contributor

@greged93 greged93 commented Aug 17, 2024 •
edited
Loading

Implement conversion between reth_primitives::Signature and alloy_primitives::Signature.

Having the From implementation simplifies conversion and avoids having to repeat the process in various repos.

@greged93 greged93 requested a review from Rjected as a code owner August 17, 2024 01:37
rkrasiuk
rkrasiuk approved these changes Aug 17, 2024
View reviewed changes
Copy link
Member

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rkrasiuk rkrasiuk added this pull request to the merge queue Aug 17, 2024
onbjerg
onbjerg approved these changes Aug 17, 2024
View reviewed changes
Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm as well

Merged via the queue into paradigmxyz:main with commit a918779 Aug 17, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkrasiuk rkrasiuk rkrasiuk approved these changes

@onbjerg onbjerg onbjerg approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@greged93 @onbjerg @rkrasiuk