Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: BlockIdReader implementation of BlockchainProvider2<DB> #10362

Merged
merged 10 commits into from
Aug 22, 2024
Merged

test: BlockIdReader implementation of BlockchainProvider2<DB> #10362

merged 10 commits into from
Aug 22, 2024

Conversation

tcoratger
Copy link
Contributor

Should close #10337

@shekhirin shekhirin changed the title storage: test BlockIdReader implementation of BlockchainProvider2<DB> test: BlockIdReader implementation of BlockchainProvider2<DB> Aug 16, 2024
@shekhirin shekhirin added A-db Related to the database C-test A change that impacts how or what we test A-blockchain-tree Related to sidechains, reorgs and pending blocks labels Aug 16, 2024
@tcoratger tcoratger mentioned this pull request Aug 17, 2024
Merged
mattsse
mattsse approved these changes Aug 22, 2024
View reviewed changes
crates/storage/provider/src/test_utils/mod.rs Outdated Show resolved Hide resolved
@mattsse mattsse enabled auto-merge August 22, 2024 06:56
@mattsse
Copy link
Collaborator

mattsse commented Aug 22, 2024

@tcoratger looks like only some import cleanup is missing

auto-merge was automatically disabled August 22, 2024 07:02

Head branch was pushed to by a user without write access

@tcoratger
Copy link
Contributor Author

@tcoratger looks like only some import cleanup is missing

Oups yeah done

shekhirin
shekhirin approved these changes Aug 22, 2024
View reviewed changes
Copy link
Collaborator

@shekhirin shekhirin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

crates/storage/provider/src/providers/blockchain_provider.rs Outdated Show resolved Hide resolved
@shekhirin shekhirin added this pull request to the merge queue Aug 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Aug 22, 2024
@shekhirin shekhirin added this pull request to the merge queue Aug 22, 2024
Merged via the queue into paradigmxyz:main with commit 7fb9a04 Aug 22, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@shekhirin shekhirin shekhirin approved these changes

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-blockchain-tree Related to sidechains, reorgs and pending blocks A-db Related to the database C-test A change that impacts how or what we test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test BlockIdReader implementation of BlockchainProvider2<DB>
3 participants
@tcoratger @mattsse @shekhirin