feat: disable l1 data gas cost in --dev mode #10332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
added
C-enhancement
shekhirin
approved these changes
Aug 15, 2024
Comment on lines
+121
to
127
| if !self.requires_l1_data_gas_fee() { | ||
| // no need to check L1 gas fee | ||
| return outcome | ||
| } | ||
|
|
||
| // ensure that the account has enough balance to cover the L1 gas cost | ||
| if let TransactionValidationOutcome::Valid { |
There was a problem hiding this comment.
nit: would prefer to do if self.requires_l1_data_gas_fee() { and check the data gas fee inside the clause, so that if we add something after balance check for l1 gas cost, we don't short circuit here
There was a problem hiding this comment.
this makes sense when we need additional checks but currently this is the only thing we're checking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in OP --dev mode we don't have an L1 block, this would just result in a bunch of issues.
hence we should just disable this entirely