Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(provider): HeaderProvider of BlockchainProvider2 #10330

Merged
merged 6 commits into from
Aug 17, 2024
Merged

test(provider): HeaderProvider of BlockchainProvider2 #10330

merged 6 commits into from
Aug 17, 2024

Conversation

shekhirin
Copy link
Collaborator

@shekhirin shekhirin commented Aug 15, 2024 •
edited
Loading

Closes #10331

@shekhirin shekhirin added A-db Related to the database C-test A change that impacts how or what we test A-blockchain-tree Related to sidechains, reorgs and pending blocks labels Aug 15, 2024
@shekhirin shekhirin changed the title test(provider): start covering BlockchainProvider2 with tests test(provider): test HeaderProvider for BlockchainProvider2 Aug 15, 2024
@shekhirin shekhirin changed the title test(provider): test HeaderProvider for BlockchainProvider2 test(provider): test HeaderProvider of BlockchainProvider2 Aug 15, 2024
@shekhirin shekhirin changed the title test(provider): test HeaderProvider of BlockchainProvider2 test(provider): HeaderProvider of BlockchainProvider2 Aug 15, 2024
@shekhirin shekhirin marked this pull request as ready for review August 15, 2024 19:55
@shekhirin shekhirin force-pushed the alexey/blockchain-provider-tests branch from 0e27a1b to d7863f5 Compare August 15, 2024 20:37
@shekhirin shekhirin added this pull request to the merge queue Aug 17, 2024
@rkrasiuk
Copy link
Member

@shekhirin pending conflicts

@shekhirin shekhirin removed this pull request from the merge queue due to a manual request Aug 17, 2024
@shekhirin
Copy link
Collaborator Author

@rkrasiuk waiting for other PRs to merge to rebase this one on top of main

@shekhirin shekhirin added this pull request to the merge queue Aug 17, 2024
Merged via the queue into main with commit 71bf5a1 Aug 17, 2024
34 checks passed
@shekhirin shekhirin deleted the alexey/blockchain-provider-tests branch August 17, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onbjerg onbjerg onbjerg approved these changes

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@gakonst gakonst Awaiting requested review from gakonst

Assignees
No one assigned
Labels
A-blockchain-tree Related to sidechains, reorgs and pending blocks A-db Related to the database C-test A change that impacts how or what we test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test HeaderProvider implementation of BlockchainProvider2
3 participants
@shekhirin @rkrasiuk @onbjerg