Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(provider): BlockchainProvider2::transaction_id #10296

Merged
merged 2 commits into from
Aug 15, 2024
Merged

feat(provider): BlockchainProvider2::transaction_id #10296

merged 2 commits into from
Aug 15, 2024

Conversation

shekhirin
Copy link
Collaborator

@shekhirin shekhirin commented Aug 14, 2024 •
edited
Loading

Ref #10181

@shekhirin shekhirin added A-db Related to the database A-blockchain-tree Related to sidechains, reorgs and pending blocks labels Aug 14, 2024
@shekhirin shekhirin marked this pull request as ready for review August 14, 2024 17:58
@shekhirin shekhirin added the C-enhancement New feature or request label Aug 14, 2024
@mvares
Copy link
Contributor

mvares commented Aug 14, 2024

@shekhirin, sorry by question, but why do you get the last block numver and sums 1?

@shekhirin
Copy link
Collaborator Author

@shekhirin, sorry by question, but why do you get the last block numver and sums 1?

Because if the database has block numbers up to 10, the first block number that's in-memory is with number 11.

@shekhirin shekhirin added this pull request to the merge queue Aug 15, 2024
Merged via the queue into main with commit 9f15670 Aug 15, 2024
35 checks passed
@shekhirin shekhirin deleted the alexey/blockchain-provider-transaction-id branch August 15, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

@fgimenez fgimenez fgimenez approved these changes

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@Rjected Rjected Awaiting requested review from Rjected

@mattsse mattsse Awaiting requested review from mattsse

Assignees
No one assigned
Labels
A-blockchain-tree Related to sidechains, reorgs and pending blocks A-db Related to the database C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shekhirin @mvares @fgimenez @DaniPopes