Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Properly bubble up InsertBlockFatalError #10276

Merged
merged 15 commits into from
Aug 26, 2024
Merged

feat: Properly bubble up InsertBlockFatalError #10276

Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
50a84e9
wip: added fatal error variant to EngineApiEvent, event listener in p…
martinezjorge Aug 12, 2024
2e8a460
Merge branch 'main' into bubble-up-insertblockfatalerror
martinezjorge Aug 16, 2024
98ac173
bubbling up the error from engine task to main task
martinezjorge Aug 16, 2024
890a8fb
result over emit, fmt, fix tests, and revert previous changes
martinezjorge Aug 17, 2024
115e9b1
touchup
martinezjorge Aug 17, 2024
70ec307
run return signature revert, adding error message to run, and reverti…
martinezjorge Aug 17, 2024
0702972
fmt
martinezjorge Aug 17, 2024
391a3aa
Merge branch 'main' into bubble-up-insertblockfatalerror
martinezjorge Aug 17, 2024
b103ac3
tests passing
martinezjorge Aug 23, 2024
e7f2d2b
Merge branch 'main' into bubble-up-insertblockfatalerror
martinezjorge Aug 23, 2024
62b3a37
touchups
martinezjorge Aug 23, 2024
3fa91f6
break on fatalinsertblockerror
martinezjorge Aug 26, 2024
5b7058e
fixing merge conflict
martinezjorge Aug 26, 2024
6cb076b
fmt
martinezjorge Aug 26, 2024
5c2d919
cleanup and touchups
martinezjorge Aug 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading