feat: track persistence metrics #10250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malik672
requested review from
rkrasiuk,
mattsse,
Rjected and
fgimenez
as code owners
mattsse
requested changes
Aug 10, 2024
| fn on_remove_blocks_above( | ||
| &self, | ||
| new_tip_num: u64, | ||
| sender: oneshot::Sender<()>, |
There was a problem hiding this comment.
this doesn't need the sender as argument
| fn on_save_blocks( | ||
| &self, | ||
| blocks: Vec<ExecutedBlock>, | ||
| sender: oneshot::Sender<Option<B256>>, |
There was a problem hiding this comment.
same here, the function should return the Option and then caller should send it
mattsse
added
the
A-observability
mattsse
requested changes
Aug 10, 2024
| } | ||
| PersistenceAction::PruneBefore(block_num, sender) => { | ||
| let start_time = Instant::now(); |
There was a problem hiding this comment.
let's also move this into prune_before, so that we're consistent with where we track metrics
There was a problem hiding this comment.
@mattsse what's latency metrics for?
Rjected
approved these changes
Aug 13, 2024
remove unnecessary code
shekhirin
requested changes
Aug 14, 2024
crates/engine/tree/src/metrics.rs
Outdated
Comment on lines
18
to
23
| /// How long it took for blocks to be removed | ||
| pub(crate) remove_blocks_above_duration: Histogram, | ||
| /// How long it took for blocks to be saved | ||
| pub(crate) save_blocks_duration: Histogram, | ||
| /// How long it took for blocks to be pruned | ||
| pub(crate) prune_before_duration: Histogram, |
There was a problem hiding this comment.
Suggested change
| /// How long it took for blocks to be removed | |
| pub(crate) remove_blocks_above_duration: Histogram, | |
| /// How long it took for blocks to be saved | |
| pub(crate) save_blocks_duration: Histogram, | |
| /// How long it took for blocks to be pruned | |
| pub(crate) prune_before_duration: Histogram, | |
| /// How long it took for blocks to be removed | |
| pub(crate) remove_blocks_above_duration_seconds: Histogram, | |
| /// How long it took for blocks to be saved | |
| pub(crate) save_blocks_duration_seconds: Histogram, | |
| /// How long it took for blocks to be pruned | |
| pub(crate) prune_before_duration_seconds: Histogram, |
| @@ -15,5 +15,7 @@ pub(crate) struct EngineApiMetrics { | |||
| pub(crate) forkchoice_updated_messages: Counter, | |||
| /// The total count of new payload messages received. | |||
| pub(crate) new_payload_messages: Counter, | |||
| /// Histogram of persistence operation durations (in seconds) | |||
| pub(crate) persistence_duration: Histogram, | |||
There was a problem hiding this comment.
Suggested change
| pub(crate) persistence_duration: Histogram, | |
| pub(crate) persistence_duration_seconds: Histogram, |
There was a problem hiding this comment.
measuring this in seconds is not useful
crates/engine/tree/src/tree/mod.rs
Outdated
| self.on_new_persisted_block(); | ||
| } else { | ||
| error!("could not find persisted block with hash {last_persisted_block_hash} in memory"); | ||
| if let Some((mut rx, start_time)) = self.persistence_state.rx.take() { |
There was a problem hiding this comment.
this changes the behavior and we won't panic anymore, do we want this? @mattsse
There was a problem hiding this comment.
right, added the expect back
crates/engine/tree/src/tree/mod.rs
Outdated
| self.last_persisted_block_number = last_persisted_block_number; | ||
| self.last_persisted_block_hash = last_persisted_block_hash; | ||
| duration |
There was a problem hiding this comment.
why do we need to return the duration here if we not used it for metrics?
There was a problem hiding this comment.
you're correct we've already used this
mattsse
approved these changes
Aug 20, 2024
crates/engine/tree/src/tree/mod.rs
Outdated
| self.last_persisted_block_number = last_persisted_block_number; | ||
| self.last_persisted_block_hash = last_persisted_block_hash; | ||
| duration |
There was a problem hiding this comment.
you're correct we've already used this
crates/engine/tree/src/tree/mod.rs
Outdated
| self.on_new_persisted_block(); | ||
| } else { | ||
| error!("could not find persisted block with hash {last_persisted_block_hash} in memory"); | ||
| if let Some((mut rx, start_time)) = self.persistence_state.rx.take() { |
There was a problem hiding this comment.
right, added the expect back
shekhirin
approved these changes
Aug 20, 2024
fgimenez
pushed a commit
that referenced
this pull request
Aug 20, 2024
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de> Co-authored-by: Alexey Shekhirin <a.shekhirin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #10220
closes #10221