fix: TreeState::on_new_head fork and reorg handling #10232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgimenez
force-pushed
the
fgimenez/fix-on-new-head-reorg-handling
branch
from
228ecc2
to
791e679
Compare
fgimenez
force-pushed
the
fgimenez/fix-on-new-head-reorg-handling
branch
from
791e679
to
f311f11
Compare
fgimenez
requested review from
rkrasiuk,
mattsse,
Rjected and
gakonst
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10179
Fixes the checks in
on_new_headfor the fork points and how we determine if we are extending the canonical chain or handling a properreorg. Includes a new test case that reproduces a hive failure.Also includes fixes in
TestBlockBuilderto make the blocks built with it work withnewPayloadby including correct signatures and some additional test refactors