Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ForkChoiceNotifications for BlockchainProvider and NoopProvider #10231

Merged
merged 5 commits into from
Aug 10, 2024
Merged

feat: ForkChoiceNotifications for BlockchainProvider and NoopProvider #10231

merged 5 commits into from
Aug 10, 2024

Conversation

royvardhan
Copy link
Contributor

@royvardhan royvardhan commented Aug 9, 2024 •
edited
Loading

Ref: #9521

@royvardhan royvardhan changed the title Feat/9521 ForkChoiceNotifications for BlockchainProvider and NoopProvider Aug 9, 2024
@royvardhan
Copy link
Contributor Author

royvardhan commented Aug 9, 2024 •
edited
Loading

Previous conversation: #10056

Sorry, I force pushed that branch and it closed the PR. Also due to old PR, it started to have conflicts with the newest state.

@royvardhan royvardhan marked this pull request as ready for review August 9, 2024 06:10
@royvardhan royvardhan changed the title ForkChoiceNotifications for BlockchainProvider and NoopProvider feat: ForkChoiceNotifications for BlockchainProvider and NoopProvider Aug 9, 2024
@royvardhan royvardhan mentioned this pull request Aug 9, 2024
Closed
mattsse
mattsse requested changes Aug 9, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last naming nits

crates/chain-state/src/chain_info.rs Outdated Show resolved Hide resolved
crates/storage/provider/src/providers/mod.rs Outdated Show resolved Hide resolved
@royvardhan
Copy link
Contributor Author

Looks good? @mattsse

@royvardhan royvardhan requested a review from mattsse August 9, 2024 16:06
@mattsse mattsse mentioned this pull request Aug 10, 2024
Merged
mattsse
mattsse approved these changes Aug 10, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work

@mattsse mattsse added the C-enhancement New feature or request label Aug 10, 2024
@mattsse mattsse enabled auto-merge August 10, 2024 14:23
@mattsse mattsse added this pull request to the merge queue Aug 10, 2024
Merged via the queue into paradigmxyz:main with commit 25ab85c Aug 10, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

Assignees
No one assigned
Labels
C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@royvardhan @mattsse