Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: detect invalid buffered block when insert fails #10217

Merged
merged 2 commits into from
Aug 8, 2024
Merged

fix: detect invalid buffered block when insert fails #10217

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b73272
fix: detect invalid buffered block when insert fails
Rjected Aug 7, 2024
b691eae
use display for insert block fatal errors
Rjected Aug 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion crates/engine/tree/src/tree/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1391,11 +1391,14 @@ where
}
Err(err) => {
debug!(target: "engine", ?err, "failed to connect buffered block to tree");
if let Err(fatal) = self.on_insert_block_error(err) {
warn!(target: "engine", %fatal, "fatal error occurred while connecting buffered blocks");
}
}
}
}

debug!(target: "engine", elapsed = ?now.elapsed(), %block_count ,"connected buffered blocks");
debug!(target: "engine", elapsed = ?now.elapsed(), %block_count, "connected buffered blocks");
}

/// Attempts to recover the block's senders and then buffers it.
Expand Down Expand Up @@ -1634,6 +1637,9 @@ where
}
Err(err) => {
debug!(target: "engine", err=%err.kind(), "failed to insert downloaded block");
if let Err(fatal) = self.on_insert_block_error(err) {
warn!(target: "engine", %fatal, "fatal error occurred while inserting downloaded block");
}
}
}
None
Expand Down
Loading