chore: derive serde traits #10198
Merged
chore: derive serde traits #10198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested changes
Aug 8, 2024
crates/trie/common/src/proofs.rs
Outdated
Comment on lines
123
to
125
| #[derive(Clone, PartialEq, Eq, Debug, Serialize, Deserialize)] | ||
| pub struct AccountProof { |
There was a problem hiding this comment.
can we do rename_all camel case?
There was a problem hiding this comment.
Oops, sorry should have checked other places where this is derived. Fixed now.
xJonathanLEI
force-pushed
the
dev/serde_traits
branch
from
d2a4e4e
to
880bbca
Compare
onbjerg
approved these changes
Aug 8, 2024
mattsse
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful traits for some downstream applications and probably harmless to derive.