Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support ms for --builder.interval #10168

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Aug 7, 2024

closes #10167

this is non breaking change that adds support for --builder.interval with ms suffix

@mattsse mattsse added C-enhancement New feature or request A-cli Related to the reth CLI labels Aug 7, 2024
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, makes sense

@mattsse mattsse enabled auto-merge August 7, 2024 14:23
@mattsse mattsse requested a review from gakonst as a code owner August 7, 2024 14:23
@mattsse mattsse added this pull request to the merge queue Aug 7, 2024
Merged via the queue into main with commit 1d46387 Aug 7, 2024
33 checks passed
@mattsse mattsse deleted the matt/support-ms-for-builder.interval branch August 7, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Related to the reth CLI C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support --build.interval in milliseconds
2 participants