Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: execute downloaded blocks in batches #10155

Merged
merged 3 commits into from
Aug 7, 2024
Merged

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Aug 7, 2024

closes #9685

introduces another config setting for how many downloaded blocks we're allowed to execute sequentially.
the remaining blocks are sent as a followup message, so that engine requests that arrived in between are prioritized.

This prevents timeout errors on CL when we're executing a larger range of blocks

@mattsse mattsse added the C-perf A change motivated by improving speed, memory usage or disk footprint label Aug 7, 2024
@github-actions github-actions bot added C-debt Refactor of code section that is hard to understand or maintain C-enhancement New feature or request labels Aug 7, 2024
Copy link
Member

@fgimenez fgimenez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, very nice!

@mattsse mattsse enabled auto-merge August 7, 2024 10:52
@mattsse mattsse added this pull request to the merge queue Aug 7, 2024
Merged via the queue into main with commit a77ce06 Aug 7, 2024
33 checks passed
@mattsse mattsse deleted the matt/split-downloaded-blocks branch August 7, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-debt Refactor of code section that is hard to understand or maintain C-enhancement New feature or request C-perf A change motivated by improving speed, memory usage or disk footprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve treeevent handling for downloaded blocks
2 participants