test: engine tree live sync, FCU extends canon chain with existing blocks #10154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C-bug
fgimenez
force-pushed
the
fgimenez/live-sync-fcu-extends-canon-chain
branch
from
504d1cc
to
9426f6e
Compare
Base automatically changed from
fgimenez/live-sync-transition-reach-canonical
to
main
August 7, 2024 10:08
… canonical chain commited event
…nical and recovered test_engine_tree_live_sync_transition_required_blocks_requested
fgimenez
force-pushed
the
fgimenez/live-sync-fcu-extends-canon-chain
branch
from
9426f6e
to
09aad7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10015
As described in #10015, I was trying to reproduce a scenario where we request to download a block already present after receiving an FCU. Given how we call
lowest_buffered_ancestor_orinon_forkchoice_updatedI couldn't reproduce any issue (at least for chains connected to the current head), before the call we had already tried to extend the existing canon chain.So the test ended up exercising canon chain extension.