-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature gate jsonrpsee
related crates and check features powerset for reth-rpc-types
#10141
Merged
mattsse
merged 5 commits into
paradigmxyz:main
from
Sovereign-Labs:sovereign/check-features-rpc-types
Aug 6, 2024
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
e2c59d2
Feature gate `jsonrpsee` related things
citizen-stig 724c3d9
Move `jsonrpsee-types` related things to a separate feature
citizen-stig 606125d
Update crates/rpc/rpc-types/Cargo.toml
citizen-stig bc212a2
Update crates/rpc/rpc-types/Cargo.toml
citizen-stig 97eb1f8
Fixes after feature rename
citizen-stig File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,15 +1,15 @@ | ||
//! Implementation specific Errors for the `eth_` namespace. | ||
|
||
use jsonrpsee_types::ErrorObject; | ||
|
||
/// A trait to convert an error to an RPC error. | ||
#[cfg(feature = "default")] | ||
pub trait ToRpcError: std::error::Error + Send + Sync + 'static { | ||
/// Converts the error to a JSON-RPC error object. | ||
fn to_rpc_error(&self) -> ErrorObject<'static>; | ||
fn to_rpc_error(&self) -> jsonrpsee_types::ErrorObject<'static>; | ||
} | ||
|
||
impl ToRpcError for ErrorObject<'static> { | ||
fn to_rpc_error(&self) -> ErrorObject<'static> { | ||
#[cfg(feature = "default")] | ||
impl ToRpcError for jsonrpsee_types::ErrorObject<'static> { | ||
fn to_rpc_error(&self) -> jsonrpsee_types::ErrorObject<'static> { | ||
self.clone() | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these should also be updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad, fixed!