Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove trait EngineApiTreeHandler #10136

Merged
merged 4 commits into from
Aug 6, 2024
Merged

Conversation

mvares
Copy link
Contributor

@mvares mvares commented Aug 6, 2024

Closes: #10123

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we keep the function docs?

@mattsse mattsse added the C-debt Refactor of code section that is hard to understand or maintain label Aug 6, 2024
@mvares
Copy link
Contributor Author

mvares commented Aug 6, 2024

can we keep the function docs?

Personally, I think the current documents made sense in the previous ones

@mvares mvares requested a review from mattsse August 6, 2024 13:16
crates/engine/tree/src/tree/mod.rs Show resolved Hide resolved
crates/engine/tree/src/tree/mod.rs Show resolved Hide resolved
crates/engine/tree/src/tree/mod.rs Show resolved Hide resolved
@mvares
Copy link
Contributor Author

mvares commented Aug 6, 2024

@mattsse, what you don't mentioned, can I remove?

@mattsse mattsse added this pull request to the merge queue Aug 6, 2024
Merged via the queue into paradigmxyz:main with commit 365012b Aug 6, 2024
32 checks passed
@mvares mvares deleted the remove-trait branch August 6, 2024 14:10
martinezjorge pushed a commit to martinezjorge/reth that referenced this pull request Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove EngineApiTreeHandler trait
2 participants