Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add EngineApiKind enum #10128

Merged
merged 5 commits into from
Aug 6, 2024
Merged

Conversation

mvares
Copy link
Contributor

@mvares mvares commented Aug 6, 2024

Partially #10124

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty, some suggestions

crates/chainspec/src/spec.rs Outdated Show resolved Hide resolved
crates/chainspec/src/spec.rs Outdated Show resolved Hide resolved
/// The type for specify which is kind of engine api
#[derive(Debug)]
pub enum EngineApiKind {
Ethereum,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be default

Copy link
Contributor Author

@mvares mvares Aug 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattsse, what does you means by defaut? (derive)

crates/chainspec/src/spec.rs Outdated Show resolved Hide resolved
crates/chainspec/src/spec.rs Outdated Show resolved Hide resolved
@mattsse mattsse added the C-enhancement New feature or request label Aug 6, 2024
@mattsse mattsse added this pull request to the merge queue Aug 6, 2024
Merged via the queue into paradigmxyz:main with commit 2e45697 Aug 6, 2024
32 checks passed
@mvares mvares deleted the engine-api-enum branch August 6, 2024 13:00
martinezjorge pushed a commit to martinezjorge/reth that referenced this pull request Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants