Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move PeersHandleProvider to new module reth_network_api::test_utils #10060

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Move PeersHandleProvider to new module reth_network_api::test_utils #10060

merged 1 commit into from
Aug 5, 2024

Conversation

emhane
Copy link
Member

@emhane emhane commented Aug 3, 2024 •
edited
Loading

Ref #10005

  • Moves PeersHandleProvider to new module reth_network_api::test_utils. Helps us get a better overview of our integration testing API.
  • Moves PeersManager types related to testing from reth-network-types into reth_network_api::test_utils

@emhane emhane added C-debt Refactor of code section that is hard to understand or maintain C-test A change that impacts how or what we test A-networking Related to networking in general labels Aug 3, 2024
@emhane emhane added the A-sdk Related to reth's use as a library label Aug 3, 2024
@mattsse mattsse added this pull request to the merge queue Aug 5, 2024
Merged via the queue into main with commit d12f0ab Aug 5, 2024
34 checks passed
@mattsse mattsse deleted the emhane/mv-peers-manager-test-api branch August 5, 2024 09:06
martinezjorge pushed a commit to martinezjorge/reth that referenced this pull request Aug 7, 2024
@emhane @martinezjorge
Move PeersHandleProvider to new module `reth_network_api::test_util…
4d8b545 
…s` (paradigmxyz#10060)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-networking Related to networking in general A-sdk Related to reth's use as a library C-debt Refactor of code section that is hard to understand or maintain C-test A change that impacts how or what we test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emhane @mattsse