feat: improve download observability #10039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested changes
Aug 2, 2024
mattsse
added
the
A-observability
mattsse
approved these changes
Aug 2, 2024
crates/engine/tree/src/download.rs
Outdated
Comment on lines
231
to
233
| if let Some(pending_event) = self.pop_pending_event() { | ||
| return Poll::Ready(pending_event); | ||
| } |
There was a problem hiding this comment.
maybe emitting here after the if self.set_buffered_blocks.is_empty() {
is problematic
we can move this to the start of the poll function because returning poll will ensure poll is called again and requests are already sent at this point
There was a problem hiding this comment.
ok, I wanted to emit the events after the first loops to advance existing requests, but emitting these new request events should happen first 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #10018