fix: drop provider before getting the next one on range queries
#10034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshieDo
added
C-bug
|
Can we add a comment why it's needed? |
mattsse
approved these changes
Aug 2, 2024
|
|
||
| let mut provider = Some(get_provider(range.start)?); |
There was a problem hiding this comment.
I see we need to move the initial provider into the iterator and need to be able to drop it before requesting the next one
1 task
1 task
martinezjorge
pushed a commit
to martinezjorge/reth
that referenced
this pull request
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a range query we iterate over files to collect all data.
There is a very small chance of hitting a deadlock if two consecutive static files share the same bucket in the internal dashmap an we don't drop the current provider before requesting the next one.