Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add prague check in ExecutionPayloadValidator #10033

Merged
merged 4 commits into from
Aug 2, 2024

Conversation

mvares
Copy link
Contributor

@mvares mvares commented Aug 2, 2024

Closes #9995

Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment otherwise looks good!

crates/payload/validator/src/lib.rs Outdated Show resolved Hide resolved
@mvares mvares requested a review from Rjected August 2, 2024 16:53
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome ty

@mvares
Copy link
Contributor Author

mvares commented Aug 2, 2024

:shipit:

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pedantic nit

crates/payload/validator/src/lib.rs Outdated Show resolved Hide resolved
@mattsse mattsse added C-enhancement New feature or request E-prague Related to the prague network upgrade labels Aug 2, 2024
@mvares mvares requested a review from mattsse August 2, 2024 18:08
@mattsse mattsse enabled auto-merge August 2, 2024 18:09
@mattsse mattsse added this pull request to the merge queue Aug 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 2, 2024
@mvares
Copy link
Contributor Author

mvares commented Aug 2, 2024

the tests is falling... @mattsse

@mattsse mattsse enabled auto-merge August 2, 2024 18:43
@mattsse mattsse added this pull request to the merge queue Aug 2, 2024
Merged via the queue into paradigmxyz:main with commit 12ccc0a Aug 2, 2024
32 checks passed
@mvares mvares deleted the check-prague branch August 2, 2024 19:11
martinezjorge pushed a commit to martinezjorge/reth that referenced this pull request Aug 7, 2024
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement New feature or request E-prague Related to the prague network upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add prague checks for ExecutionPayloadValidator
3 participants