Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use UnifiedStorageWriter::commit where possible #10019

Merged
merged 6 commits into from
Aug 2, 2024
Merged

chore: use UnifiedStorageWriter::commit where possible #10019

merged 6 commits into from
Aug 2, 2024

Conversation

joshieDo
Copy link
Collaborator

@joshieDo joshieDo commented Aug 2, 2024

Some small drive–bys:

  • Make database non optional
  • Use from_database and from where possible
  • rename StorageWriter to UnifiedStorageWriter
  • use UnifiedStorageWriter::commit and UnifiedStorageWriter::commit_unwind where necessary.

@joshieDo joshieDo added A-db Related to the database A-static-files Related to static files labels Aug 2, 2024
@joshieDo joshieDo enabled auto-merge August 2, 2024 13:58
@joshieDo joshieDo added this pull request to the merge queue Aug 2, 2024
Merged via the queue into main with commit 06fbdd9 Aug 2, 2024
32 checks passed
@joshieDo joshieDo deleted the joshie/tunesw branch August 2, 2024 14:25
@mvares mvares mentioned this pull request Aug 2, 2024
Closed
@joshieDo joshieDo mentioned this pull request Aug 5, 2024
Closed
martinezjorge pushed a commit to martinezjorge/reth that referenced this pull request Aug 7, 2024
@joshieDo @martinezjorge
chore: use UnifiedStorageWriter::commit where possible (paradigmxyz…
2c96ca1 
…#10019)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

Assignees
No one assigned
Labels
A-db Related to the database A-static-files Related to static files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshieDo @mattsse