Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tx-pool: add Default impl for TransactionOrigin #10013

Merged
merged 1 commit into from
Aug 2, 2024
Merged

tx-pool: add Default impl for TransactionOrigin #10013

merged 1 commit into from
Aug 2, 2024

Conversation

tcoratger
Copy link
Contributor

Useful for mock or noop implementations to avoid importing TransactionOrigin and use Default::default() instead.

@tcoratger tcoratger requested a review from mattsse as a code owner August 2, 2024 09:11
mattsse
mattsse approved these changes Aug 2, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

@mattsse mattsse added this pull request to the merge queue Aug 2, 2024
@mattsse mattsse added the A-tx-pool Related to the transaction mempool label Aug 2, 2024
Merged via the queue into paradigmxyz:main with commit b2b1b53 Aug 2, 2024
33 checks passed
martinezjorge pushed a commit to martinezjorge/reth that referenced this pull request Aug 7, 2024
@tcoratger @martinezjorge
tx-pool: add Default impl for TransactionOrigin (paradigmxyz#10013)
e9230f4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

Assignees
No one assigned
Labels
A-tx-pool Related to the transaction mempool
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tcoratger @mattsse